search

skanaar / nomnoml

The sassy UML diagram renderer
https://www.nomnoml.com
MIT License
2.66k stars 208 forks source link

Fix/support for short color notation #194

Open bdlabs opened 1 year ago

bdlabs commented 1 year ago

Fixed render svg. Add support for short color notation.

skanaar commented 1 year ago

Very interesting to let uers register their own styles! I will have to think a bit about this as this new public API will freeze the current implementation of layouters and visualizers.

bdlabs commented 1 year ago

OK, can you explain how? Maybe I missed something :)

skanaar commented 1 year ago

@bdlabs the sames changes appear in both this PR and in #193 . I got a bit confused.

What I mean is that right now the layouter and visualizer systems are private parts of nomnoml. So I am free to change them around whenever without breaking the public API.

If they are exposed they are "locked into place" and any changes to those systems would mean a breaking change. So I would have to think carefully about that.

skanaar commented 1 year ago

Could you remove the stuff related to registerComponent from this PR so it only deals with the color notation? Thanks

bdlabs commented 1 year ago

My mistake, I did the merge wrong, didn't notice it :), I'll fix it today. Thanks.

bdlabs commented 1 year ago

Hi, what about this theme? :)

skanaar commented 1 year ago

Thank you for the reminder. I'm on a short vacation for the moment, will look at this next week.

skanaar commented 1 year ago

@bdlabs which SVG viewer are you using that gave you a buggy rendering? Because I cannot reproduce the bug that this is supposed to solve.

bdlabs commented 1 year ago

@skanaar sorry, I don't remember. It was probably a render in phpstorm.

skanaar commented 1 year ago

Hmm, I will close this PR since I cannot reproduce the bug. But I really appreciate the effort.

skanaar commented 1 year ago

Reopening as I can reproduce it in JetBrains Fleet.