search

skanaar / nomnoml

The sassy UML diagram renderer
https://www.nomnoml.com
MIT License
2.66k stars 208 forks source link

[enhancement] Variable radius for roundrect visual #65

Closed markwalet closed 5 years ago

markwalet commented 6 years ago

Just like the title says. This could be something you set on a Custom classifier style, or as a global directive.

skanaar commented 6 years ago

The current roundrect visual should probably be renamed capsule (since radius = height/2) and roundrect changed to be an actual rounded rectangle, probably with radius = lineHeight/2.

I would gladly accept a pull request with such a change.

However, introducing directives for specific attributes in visuals could be like opening pandoras box. It implies that every hard-coded parameter in every visual should be configurable, which cause an explosion in the number of directives. I would much rather introduce a concept of custom visuals instead.

markwalet commented 6 years ago

I'll see what I can do