skanaar / nomnoml

The sassy UML diagram renderer
https://www.nomnoml.com
MIT License
2.66k stars 208 forks source link

Modifier classes don't work with underscore.js #88

Closed ronkok closed 5 years ago

ronkok commented 5 years ago

When testing PR #87, I found that modifier classes do not work when I employ underscore.js. Go ahead and try a modifier class in the test folder. It won't work.

All classes work fine when I use lodash.

The problem seems to occur at a line that calls _.includes(). underscore expects the argument to be an array. lodash also accepts a string.

Maybe now is a good time to standardize on lodash?

ronkok commented 5 years ago

Fixed by #87.