Zoom and pan actions don't display with invalid code.

skanaar / nomnoml

The sassy UML diagram renderer

https://www.nomnoml.com

MIT License

2.66k stars 208 forks source link

Zoom and pan actions don't display with invalid code. #99

Closed Andrew-SK closed 5 years ago

Andrew-SK commented 5 years ago

When you have invalid code the diagram it appears as though you can't zoom or pan around.

Once you correct the code then the diagram re-renders revealing that attempts to move the diagram were successful.

I would have expected that either the zooming and panning would actually be disabled with invalid code or the diagram would render zoom and pan changes despite the invalid code.

skanaar commented 5 years ago

Hmm, sound like a bug!

Andrew-SK commented 5 years ago

I made PRs #100 and #101 with the smallest changes I could think of.

skanaar commented 5 years ago

Nice, thank you for the assistance :)

Andrew-SK commented 5 years ago

Sorry @skanaar, I should have been more clear. I only intended for you to merge one PR or the other, not both 😅 I would suggest reverting 101.

Andrew-SK commented 5 years ago

See #102 for a reversion of PR #101. Sorry again for the confusion, @skanaar.

skanaar commented 5 years ago

Ah, I did think: "Won't these sort of cancel each other out". But I assumed that they were both needed for some corner case.