search

skandasoft / open-unsupported-files

open file using external program
https://atom.io/packages/open-unsupported-files
MIT License
11 stars 4 forks source link

Not work in Atom 1.16.0 #12

Closed TerminusBot closed 7 years ago

nanichandu84 commented 7 years ago

Have the same issue with Atom 1.16.0.

questuk commented 7 years ago

Same as above on Atom 1.16.0.

mcocdawc commented 7 years ago

I got the same problem. Steps to reproduce are simple: Just click a file with a not supported file format.

See the stack trace in the attached file stack_trace.txt.

Atom: 1.16.0 x64 Electron: 1.3.13 OS: Ubuntu 16.04.2 Thrown From: open-unsupported-files package 1.0.19

weslo commented 7 years ago

Ayo, fixed this issue in my pr #13

weslo commented 7 years ago

@skandasoft

truenicoco commented 7 years ago

Accepting this PR would be great! Anyway, thanks @Weslo for this quickfix.

weslo commented 7 years ago

@truenicoco confirmed it worked for you too? Want to double check it wasn't just an issue on my machine.

truenicoco commented 7 years ago

Exact same issue and your solution is working here. Latest atom in Fedora 25.

TerminusBot commented 7 years ago

@skandasoft #13 PR works very well for me. Thank @Weslo

weslo commented 7 years ago

Hoping @skandasoft will hop on soon, but if not, anyone know how I can update the atom package or if I need to create a new one? Want to make sure the public package doesn't have errors in the current release of atom...

weslo commented 7 years ago

For the time being, I'll be adding fixes to my fork

skandasoft commented 7 years ago

need to get back...I will check your PR and accept it..thanks for pitching in.

alugarius commented 7 years ago

please fix it soon

jailsonfm commented 7 years ago

It's not working for me too. I have the Atom 1.17.0. I am using mac OSX 10.9.5. I can install without any problem, but no office file can be opened properly (.doc, .docx, .pptx.). I just can see a lot of question marks and undefined text instead. I am looking forward to seeing it working! Thanks

weslo commented 7 years ago

@jailsonfm Did you try my fix in Atom 1.17.0? If so, are there any issues with my adjustments?

jailsonfm commented 7 years ago

Hi Weslo, thanks for your friendly support. But, I didn't really understand how the people above managed to fix the problem. Is it related to the #13?. Should I copy and add the code somewhere? Jai

jailsonfm commented 7 years ago

I modified the "lib/open-unsupported-files.coffee" according to the #13 changes but I still can't visualize the ".docx" properly. Just something like that: "(�;|D�-��ܠ��P�Z�P�c����/"

TerminusBot commented 7 years ago

just replace the package file

~/.atom/packages/open-unsupported-files/lib

weslo commented 7 years ago

@jailsonfm Sorry I'm not sure I understand the issue. Try updating your package via my fork of this project and see if that fixes the issue!

skandasoft commented 7 years ago

thanks @Weslo . Merged.