search

skandragon / thing

Apache License 2.0
8 stars 10 forks source link

Search doesn't search enough #101

Open wumpus opened 10 years ago

wumpus commented 10 years ago

I was expecting to be able to enter Gregory in the custom schedule search box and see all my classes -- but it seems that that box only searches the class titles?

wumpus commented 8 years ago

I was reminded of this issue today --- I searched for [Music], and it matched all classes with Music/Musician etc in the class title, but not the classes in categories with "music" in the category name.

In the results page (SERP), the categories aren't clickable... would be nice.

Also, if you search for something that gets no matches, the UX leaves you at a dead end -- it's a SERP page with no results, no explanation of what happened

wumpus commented 7 years ago

This bug still exists -- if you type [dance] into the search box, only about 2/3 of the dance classes appear. So, for example, the Blue Feather Ball doesn't appear because it doesn't have 'dance' in the title or description, but it's in the Dance category. ("dancing" does appear in the description.)

wumpus commented 5 years ago

I'm not enough of a Rubyist to make a pullreq for this, but, making the search more enthusiastic is a one-line change to controllers/users/schedules_controller.rb, where

162:      @instructables = @instructables.where('name ILIKE ?', "%#{@search.strip}%")

could be changed to something like:

'name ILIKE ? OR topic ILIKE ? or culture ILIKE ? or description_web ILIKE ? or description_book ILIKE ?'

That doesn't fix the "no results" dead end, but I would find this one-line fix very useful.