Retrieve torrent and tracker info with a single RPC.

skangas / mentor

mentor is a GNU Emacs frontend for the rTorrent bittorrent client.

GNU General Public License v3.0

81 stars 8 forks source link

Retrieve torrent and tracker info with a single RPC. #11

Closed nicolasavru closed 5 years ago

nicolasavru commented 5 years ago

Embedding a t.multicall inside a d.multicall allows us to send only a single RPC per torrent instead of 1 RPC to retrieve the torrent data and then one additional RPC for each of the torrent's trackers.

With ~1600 torrents loaded in rtorrent, this reduces the run time of (mentor) (from a fresh start) from ~5.9 seconds to ~3.4 seconds).

skangas commented 5 years ago

This looks like a great idea! Sorry for being slow to reply - I've been swamped with work lately, but I'll try to review this in the next week or two, and hopefully get it merged. Even better to see that you added some ert tests.

skangas commented 5 years ago

Merged. Thanks!

nicolasavru commented 5 years ago

Sent #16 to fix the copy/paste error you caught. Thanks.

Sorry I didn't reply before you merged it, I've been similarly busy.

skangas commented 5 years ago

No worries, thanks for the fix!