skardhamar / rga

R Google Analytics
186 stars 88 forks source link

Automatic pulling of all data (when the max attribute is excluded) doesn't work when walk=T #51

Open BrianWeinstein opened 10 years ago

BrianWeinstein commented 10 years ago

When the max attribute is excluded from the ga$getData() function AND batch=T AND walk=T, the automatic pulling of all rows isn't working.

Ideally, we'd walk through the time period pulling data for one day at a time, and on each day we'd detect the total number of rows and pull all of the data for that day.

For example, for June 1–30, with batch=T, walk=T and the max attribute excluded, I currently see screen shot 2014-07-24 at 11 44 31 am

Ideally, though, the automatic detection of the max number of rows would occur on each day, similar to how it does when the query includes only one day. For example, for June 1 only, with batch=T, walk=T and the max attribute excluded, I currently see screen shot 2014-07-24 at 11 52 21 am

Let me know if any additional information would be helpful.

Thanks for the awesome package!

BrianWeinstein commented 10 years ago

Likely related to: https://github.com/skardhamar/rga/issues/46 https://github.com/skardhamar/rga/issues/45