search

skardhamar / rga

R Google Analytics
186 stars 89 forks source link

Walk function doing one day more #77

Open alexsnsk opened 8 years ago

alexsnsk commented 8 years ago

Hello,

I'm using the WALK = TRUE function to avoid sampled data and it is doing a day more than the end date. Call: getData(ID, batch = TRUE, walk = TRUE, "2015-09-01", "2015-10-31" metrics = "ga:sessions,ga:bounces,ga:sessionDuration,ga:pageviews", dimensions = "ga:month", sort ="ga:month")

but it's running also for 2015-11-01.

Any tips?

mattpolicastro commented 8 years ago

This might be a crackpot theory, but which time zone is your GA account configured to use?

EricGoldsmith commented 8 years ago

This may be the bug I ran into, and fixed in my local fork. I'm afraid I've not gotten around to issuing a pull request for it.

alexsnsk commented 8 years ago

I think the problem is not in the timezone. I've been running the exact code to extract monthly reports whithout a problem.

Seems like @EricGoldsmith is in the right direction. Yesterday testing I saw that the walks.max was giving some inacurate date diffs. ( 2015-09-01 to 2015-10-31 = 62 days :O)

EricGoldsmith commented 8 years ago

I submitted a PR for this update: https://github.com/skardhamar/rga/pull/81

EricGoldsmith commented 8 years ago

@alexsnsk, @mattpolicastro, @skardhamar, thoughts on merging this PR?

alexsnsk commented 8 years ago

I think it is a must!! Nice work there!

2016-02-29 15:21 GMT+01:00 Eric Goldsmith notifications@github.com:

@alexsnsk https://github.com/alexsnsk, @mattpolicastro https://github.com/mattpolicastro, @skardhamar https://github.com/skardhamar, thoughts on merging this PR?

— Reply to this email directly or view it on GitHub https://github.com/skardhamar/rga/issues/77#issuecomment-190228588.

mattpolicastro commented 8 years ago

👍

EricGoldsmith commented 8 years ago

@alexsnsk, can you confirm that this is now fixed, and then close this issue?