When walk = TRUE and batch = TRUE are both used, and the daily results exceed 10,000 rows, the bulk operation incorrectly only retrieves the first 10,000 rows.
This appears to have been reported in various forms in the past: #21, #46, and #61.
I've tested it on my end, and it looks good. But, before I submit a PR, I'd appreciate some additional testing from those who've also encountered this issue.
In addition the batch fix, that branch also contains:
Default to HIGHER_PRECISION data sampling - making results deterministic (the 'DEFAULT' setting is not)
Update link to API v3 docs for max results size, correct syntax of error message
Modify logic to to allow 'max' to be adjusted when 'batch' is specified (fixes issue of 'batch' option not working correctly with 'walk' option)
When
walk = TRUEandbatch = TRUEare both used, and the daily results exceed 10,000 rows, the bulk operation incorrectly only retrieves the first 10,000 rows.This appears to have been reported in various forms in the past: #21, #46, and #61.
I believe I have fixed this issue in this branch of my local fork: https://github.com/tedconf/rga/tree/fix-batch
I've tested it on my end, and it looks good. But, before I submit a PR, I'd appreciate some additional testing from those who've also encountered this issue.
In addition the batch fix, that branch also contains:
/cc @40-02, @joaolcorreia, @AlunHewinson, @kingo55, @lunametrics, @MarkEdmondson1234, @Kusara, @skardhamar