skarnet / s6

The s6 supervision suite.
https://skarnet.org/software/s6/
ISC License
760 stars 34 forks source link

notifyoncheck does not kill check after localtimeout #37

Closed brian-mcnamara closed 6 months ago

brian-mcnamara commented 6 months ago

We are using notifyoncheck to call the data/check program with -t 5000 to set a 5 second timeout for the check program to exit. There are times when the logic of the check script hangs (child process never returns). In this case, I expect notifyoncheck to kill the check and start a new one. However we are seeing multiple checks all running in the same time.

Based on https://github.com/skarnet/s6/blob/master/src/supervision/s6-notifyoncheck.c#L254, it seems like contrary to the documentation, the process is not killed and another check is performed.

brian-mcnamara commented 6 months ago

Never mind, its not the process that remains, its the children. My mistake.