skarrmann / horizon

52 key ortholinear keyboard, no special features.
MIT License
125 stars 9 forks source link

Python plugin doesn't work in KiCad 7 #5

Closed Pe8er closed 9 months ago

Pe8er commented 9 months ago

Hi!

I'm making an attempt to reduce the size of your fantastic design to 10 columns. However, the board producer plugin throws the following error in KiCad 7:

Traceback (most recent call last):

File "/Users/pe8er/Documents/KiCad/7.0/3rdparty/plugins/horizon-board-producer-plugin.py", line 20, in Run
HorizonBoardProducerPlugin.produce()

File "/Users/pe8er/Documents/KiCad/7.0/3rdparty/plugins/horizon-board-producer-plugin.py", line 248, in produce
HorizonBoardProducerPlugin.__create_gerbers(pcb, gerber_output_path)

File "/Users/pe8er/Documents/KiCad/7.0/3rdparty/plugins/horizon-board-producer-plugin.py", line 41, in __create_gerbers
plot_options.SetExcludeEdgeLayer(True)

AttributeError: 'PCB_PLOT_PARAMS' object has no attribute 'SetExcludeEdgeLayer'

Any chance you could fix it please? Thanks a ton!

skarrmann commented 9 months ago

Hello!

Yes, I will try migrating the board generator plugin code to KiCad 7 within the next couple days. It was last migrated to KiCad 6, so it needs to be updated again.

I will let you know how it goes.

Pe8er commented 9 months ago

Thanks and good luck!

skarrmann commented 9 months ago

Thanks!

Can you please try running this updated plugin code in KiCad 7? https://github.com/skarrmann/horizon/blob/ec8f4e240b31b75347d11e4e73a34dd3b1617870/kicad-plugins/horizon-board-producer-plugin.py

I confirmed the update works for me on KiCad 7.0.9. Please note KiCad will forcefully close after the plugin successfully runs. You should see this message if the plugin successfully generated the fabrication files:

kicad-7-horizon-board-producer-complete-message

Let me know if this updated code works for you. If it's good, I will merge this update into the main project. Thank you!

Pe8er commented 9 months ago

It works on KiCad 7.0.8 on Mac, and the script kills KiCad at the end. I reviewed the gerbers as best as I could, they looked fine so I just submitted an order 😀 Thank you so much!

skarrmann commented 9 months ago

Great! Thank you for testing this update.

Good luck with your Horizon Mini, and I'd love to hear how the build goes.

Pe8er commented 8 months ago

I will let you know for sure, hopefully it works 🤞

Pe8er commented 6 months ago

@skarrmann Hey! It is alive! 😀 Thank you for brilliant idea and design!

horizon-mini

There is just one remaining issue: it seems like the battery is not charging. I don't know if the battery is broken or is it something with my soldering, or maybe ZMK. I'm off to get help on ZMK Discord.

skarrmann commented 6 months ago

Your board looks fantastic, congratulations!

Good luck with the battery charging issue. I'm sure the ZMK Discord help you with troubleshooting.