skartknet / Iconic

The ultimate icon picker for Umbraco backoffice
MIT License
7 stars 8 forks source link

Can't use absolute path for CSS file #19

Closed inversiondk closed 2 years ago

inversiondk commented 2 years ago

Just downloaded version 3.2.0 of this awesome package with Umbraco 10. In the documentation it states "You can use absolute or relative paths" for the CSS file. However - when you create your data type, you only get a local file picker with no option to select an absolute path. I have my font kit hosted at a CDN and would very much like to use this option. Is this new functionality by design?

Thanks a lot :)

skartknet commented 2 years ago

Hi @inversiondk , the first versions of Iconic had a textbox to enter the URL of your CSS file. To improve the user experience I decided to create the picker, and I missed the fact that a textbox would still be useful!

I'll fix that as soon as I can. Thank you for bringing that up.

inversiondk commented 2 years ago

@skartknet cool. It's not something that breaks the entire setup - I was just wondering. Very very cool little plugin. Thanks for creating it :)

skartknet commented 2 years ago

I have done some modifications to support this.... but I haven't tested it. Maybe someone can give it a try...?

I have created a version 4.1.0-beta with it.

inversiondk commented 2 years ago

I'll see if I can't give it a try with an upcoming project :)

a-t-k commented 2 years ago

I cant find location, where we can enter absolute URL.

skartknet commented 2 years ago

I have created a new version beta2, beta1 had a bug. You should see the input boxes. image

onza22 commented 2 years ago

@skartknet Added beta2, when using the picker (select button) it then breaks the functionality? image image

@inversiondk how do you plan to use the kit, isn't the kit just a JS file?

huwred commented 2 years ago

I also get an isExternalUri is undefined using beta 2

skartknet commented 2 years ago

thanks guys, I have fixed that issue that @onza22 said, but I couldn't replicate the one from @huwred. It seems to be working fine now.

skartknet commented 2 years ago

I have created a beta3

skartknet commented 2 years ago

I have found the error for isExternalUri. I will fix this, don't test anything yet. Thanks.

huwred commented 2 years ago

I have found the error for isExternalUri. I will fix this, don't test anything yet. Thanks.

Hi, any update on this one?

skartknet commented 2 years ago

I'm working on a new version with some other changes... and a new exciting feature ;). I hope I get it ready by the end of the week.

skartknet commented 2 years ago

I have created a beta4. Hopefully it works this time. I'm also shipping a few other improvements on this version like a Filter option. Still need to update the docs though.

huwred commented 2 years ago

:( beta4 seems to have broken it completely so had to revert back to beta 3. I will take a deeper look later and report back.

huwred commented 2 years ago

fixed the back office issue, I had to delete the old app_plugins folder, however I now get an error in the ui

Unable to cast object of type 'Our.Iconic.IconicPackagesConfiguration' to type 'System.Collections.Generic.Dictionary2[System.String,System.Object]'.`

at Our.Iconic.Core.ConfiguredPackagesCollection.GetConfiguratedPackages(IPublishedPropertyType propertyType) at Our.Iconic.Core.ValueConverters.IconicValueConverter.ConvertIntermediateToObject(IPublishedElement owner, IPublishedPropertyType propertyType, PropertyCacheLevel referenceCacheLevel, Object inter, Boolean preview) at Umbraco.Cms.Core.Models.PublishedContent.PublishedPropertyType.ConvertInterToObject(IPublishedElement owner, PropertyCacheLevel referenceCacheLevel, Object inter, Boolean preview) at Umbraco.Cms.Core.PublishedCache.PublishedElementPropertyBase.GetValue(String culture, String segment) at Umbraco.Extensions.PublishedPropertyExtension.Value[T](IPublishedProperty property, IPublishedValueFallback publishedValueFallback, String culture, String segment, Fallback fallback, T defaultValue) at Umbraco.Extensions.PublishedElementExtensions.Value[T](IPublishedElement content, IPublishedValueFallback publishedValueFallback, String alias, String culture, String segment, Fallback fallback, T defaultValue) at Umbraco.Cms.Web.Common.PublishedModels.MenuItem.get_Icon() in E:\Umbraco-Dev\VantagePortal\VantagePortal.ContentModels\MenuItem.generated.cs:line 65

skartknet commented 2 years ago

I'll take a look. Thanks for taking the time to test it.

huwred commented 2 years ago

All seems OK so far in the beta5

skartknet commented 2 years ago

I'll close this for now.