search

skartknet / Iconic

The ultimate icon picker for Umbraco backoffice
MIT License
7 stars 8 forks source link

Overlay not opening correctly for infinite editing (Umbraco 10.2.0) #20

Closed hfloyd closed 2 years ago

hfloyd commented 2 years ago

I just updated my website to Umbraco 10.2.0, and today I noticed that the iconic overlay was no longer usable - it doesn't open full-height: image

Specifically my usage is of a nested Content Block property, using the default view with a "Medium" overlay: image

I don't see any errors in the browser console.

I also tested by just putting the property onto a Content node, and when clicking on it the screen gets a transparent white overlay, but there is no iconic overlay visible.

Has anyone else noticed this?

skartknet commented 2 years ago

I was able to reproduce on a new 10.2.0 installation. Just a doctype with an Iconic property. The overlay doesn't open at all. I'm looking into it.

Alaeddinalhamoud commented 2 years ago

Same Issue :(

hfloyd commented 2 years ago

Not at all sure if this is the issue, but I did see this property editor problem created by 10.2 :https://github.com/leekelleher/umbraco-contentment/issues/250

skartknet commented 2 years ago

I finally could take a look. The UmbOverlay directive has been deprecated for a long time now, and something in the version 10.2.0 has broken it. I have replaced it with the overlayService. It seems to be working now. Can you please give it a try?

The new version is v4.0.0

hfloyd commented 2 years ago

It works!!! Thanks so much for the quick fix, @skartknet 😊

ghost commented 2 years ago

No matter how I install 4.0, I'm still getting the old files. It all says 4.0 is installed. I even removed the package and reinstalled it.

Alaeddinalhamoud commented 2 years ago

I have the same issue, Clean the project, delete bin and obj folders rebuild. should be fine ;)

ghost commented 2 years ago

@Alaeddinalhamoud It works! Awesome, thank you!