Closed robertjf closed 1 year ago
It's worth noting that ConditionalDisplayers also suffers from the same problem.
Hey @robertjf , just a note that it looks weird that both packages have the same problem. Iconic is a Razor Class but CD is not. 🤷
Also, I'm not sure if the lastest version of Iconic is meant to work on v8...
Given that the latest version of Iconic is a RCL, there shouldn't be any folder in App_Plugins. All is contained in the Iconic DLL
Remove all the old iconic files, including any target files that you had.
Umbraco V8 targets .NET 4.7 but the latest Iconic targets net6 and 7.
Hey @skartknet apologies - we're using Our.Iconic 4.0.0 and Our.Iconic.Core 3.2.0.
We've arrived at a solution with the CI/CD build that gets around the issue - split the VSBuild@1 task into two steps - one to clean and build, the other to publish:
- task: VSBuild@1
inputs:
solution: '$(solution)'
platform: '$(buildPlatform)'
configuration: '$(buildConfiguration)'
msbuildArgs:
clean: true
msbuildArchitecture: 'x64'
createLogFile: true
- task: VSBuild@1
inputs:
solution: '$(solution)'
platform: '$(buildPlatform)'
configuration: '$(buildConfiguration)'
msbuildArgs: /p:DeployOnBuild=true /p:WebPublishMethod=Package /p:PackageAsSingleFile=true /p:SkipInvalidConfigurations=true /p:PackageLocation="$(build.artifactstagingdirectory)\\"
clean: false
msbuildArchitecture: 'x64'
createLogFile: true
We also discovered that the latest ConditionalDisplayers does not work on Umbraco 8 due to the use of uUI - I'll add an issue on the appropriate repository for you.
I've been investigating why the iconic files haven't been updating properly on some installs we have where we use AzureDevOps CI/CD to do the installation.
Umbraco: 8.18.17 Our.Iconic: latest (upgraded from Koben.Iconic).
We discovered this issue while attempting to upgrade from Koben.Iconic, and found that the package manifest on the server still referenced Koben.Iconic after a push.
What I've found happening is this (from the CI/CD logs):
The project file is configured to not include the app_plugins\Iconic directory - if it does, then the CI/CD fails when attempting to publish the files as they are deleted by step 1 above.
An example of the CI/CD yaml: