skartknet / Iconic

The ultimate icon picker for Umbraco backoffice
MIT License
7 stars 8 forks source link

Not compatible with Umbraco 11/AspNetCore 7 #36

Closed afabri73 closed 1 year ago

afabri73 commented 1 year ago

Hi, There are problems with Umbraco 11/AspNetCore 7 I tried to create a new Custom Package but I cannot save it.

Can you update the package to make it compatible with Umbraco 11/AspNetCore 7?

Thank you Adriano

skartknet commented 1 year ago

Hi Adriano,

I have tested the latest Iconic version 5.2.1 with Umbraco 11.4.4 and it's working fine. Can you give more information like:

robertjf commented 1 year ago

@afabri73 it's also worth looking at the Browser Dev Tools (typically F12) when reporting the error - are there any errors in the javascript console?

afabri73 commented 1 year ago

HI Robert, I'm using the latest stable Umbraco release v11.4.0 and the latest stable version of Our.Iconic v5.2.1

There several problems:

After Our.Iconic installation, Umbraco are very unstable in all environments and I receive several UmbracoAPI error. Uninstalling Our.Iconic, the system becomes stable again

In the console I received some errors, but i didn't think about taking screenshots and now i uninstalled the package This is a fresh Umbraco and Our.Iconic installations (no update)

Thank you for the support Adriano

skartknet commented 1 year ago

If you have removed the package and are unable to reproduce I'm afraid we can't help you. If you try to install it again and we can get an idea what the errors are please reopen this ticket.

I'm closing it because we can't reproduce.

afabri73 commented 1 year ago

Hi, I reinstalled your package (v5.2.1) and in my local machine it function properly. I configured all as you describe, I correctly pick the Icon and I see the icon in frontend. After I publish to my developer website I cannot manage the Iconic Package Configurations and I cannot use the picker in content.

DEVELOPER WEBSITE

When I go to Settings > Datatype > Iconic - Icon Picker I don't see the package configuration I created. SS1 - Datatype

I see an error in Console SS2 - Error

And in Content Section I don't see selected icon and can't use the Add button (no action after pressed). SS3 - Content IconPicker

LOCAL WEBSITE (My PC) same DB used with Developer Website

ss1 - Datatype (local)

SS3 - Content IconPicker (local)

Can you reopen the issue and can you give me support? Thank you Adriano

robertjf commented 1 year ago

@afabri73 this may be a similar issue for you to this one on the gmaps repository:

https://github.com/ArnoldV/Our.Umbraco.GMaps/issues/145

Try changing the smidge cachebuster settings and see if that resolves it for you.

afabri73 commented 1 year ago

Hi Robert, first of all thank you for the support. Thanks to the link you sent me I found that the problem is indeed due to the cache configuration. What I don't understand is why the Developer Website site didn't use the Development configuration. Indeed in base appsettings.json I had this configuration:

"RuntimeMinification": {
    "UseInMemoryCache": false,
    "CacheBuster": "Version",
    "Version": "1234"
}

while in appsettings.Development.json I had this configuration:

"RuntimeMinification": {
    "UseInMemoryCache": true,
    "CacheBuster": "Timestamp"
}

So it seems that development configuration didn't overriding the base appsettings. So I tried to publish the project specifying the environment and this solved the problem.

dotnet publish $sourcePath\$solutionName\$projectName\$progectFile -o $destinationPath -f net7.0 -c Debug /p:EnvironmentName=Development

Thanks again for the support Adriano