search

skaslev / gl3w

Simple OpenGL core profile loading
http://github.com/skaslev/gl3w
The Unlicense
705 stars 157 forks source link

Added Feature: Custom directory #36

Closed ghost closed 7 years ago

ghost commented 8 years ago

Allows for Custom Directory Specification from command line with $python gl3w_gen.py new_dir

tombsar commented 7 years ago

I like the idea of this PR. A couple of comments:

  1. The diff shows a lot of whitespace changes that are unrelated to this PR. This is probably your editor stripping out empty lines automatically, which should maybe be done, but in a separate PR.

  2. I would prefer using something like os.path.join and/or os.path.abspath when combining strings to specify directories. I don't believe the current solution handles the case of new_dir ending with a / correctly.

ghost commented 7 years ago

@tombsar Right, i think that was the beautifier with atom, and sure, i'll sort out those to things