Closed jpnelson closed 7 years ago
@justinfagnani can you confirm that there are no breaking changes between these two shas?
Uh, no... what is this?
@justinfagnani sorry to pull you in, we're depending on a sha on the v1
branch of webcomponents.js 's CustomElement polyfill. It looks like bumping the version of that fixes some issues that we had with the polyfill. I was just wondering if there are any breaking changes in the diff, I'm struggling to tell.
Did you mean "no" as in you can't confirm? Or "no" as in there are no breaking changes?
Well, I don't know what those SHAs point to, but there haven't been any spec changes that I've incorporated, so the public-facing API should be the same. The polyfill adds CustomElementsRegistry#flush(), but that should work the same as ever.
The polyfill isn't released yet though, so I can't commit to no changes. In particular I'm look at making the whole thing synchronous.
Ok, it's probably good for us to stay on top of the updates anyway. The later one is today, and I was comparing it with June 28th – looks like there have been quite a few changes in that time. I was just interested in whether there were any dramatic changes that you knew about.
Thanks!
LGTM
This was needed due to a problem with loading skate in the head - particularly around 's that aren't type import, and so link.import was undefined. It's fixed in the later version.