search

skatejs / web-components

[DEPRECATED] - The frictionless way to use the webcomponents/webcomponentsjs polyfills.
MIT License
17 stars 4 forks source link

ShadyCSS doesn't work in IE11 #34

Closed elmariofredo closed 7 years ago

elmariofredo commented 7 years ago

The reason is because <template> is not implemented in IE11.

One can of course add template polyfill like here http://codepen.io/elmariofredo/pen/mRazLq but from my understanding it doesn't have much sense to have shadyCss but not template polyfill in skate-web-components package.

Please let me know what do you think.

treshugart commented 7 years ago

Happy to add it to make it IE11 compat. Woud you mind PR'ing? Seems you have the ability to easily test it at the moment.

elmariofredo commented 7 years ago

Sure PR is on its way

Hotell commented 7 years ago

related https://github.com/webcomponents/shadycss/issues/51

elmariofredo commented 7 years ago

done... sorry it took so long got stuck between my birthday party and "awesome" IE11 debug tools 😉

treshugart commented 7 years ago

Happy birthday! Thanks for the PR; reviewing now.