search

skatejs / web-components

[DEPRECATED] - The frictionless way to use the webcomponents/webcomponentsjs polyfills.
MIT License
17 stars 4 forks source link

npm install skatejs-web-components is broken #36

Closed camargo closed 7 years ago

camargo commented 7 years ago

When installing the most recent version of skatejs-web-components with npm I'm getting the error:

Invalid Package: expected @webcomponents/template but found template.

Node version: 7.5.0 Npm version: 4.1.2

treshugart commented 7 years ago

Works if you use yarn. I think NPM is complaining that their name isn't @webcomponents/template, but just template: https://github.com/webcomponents/template/blob/master/package.json#L2

treshugart commented 7 years ago

PR open for @webcomponents/template https://github.com/webcomponents/template/pull/9. To work around it, you can just use Yarn.

treshugart commented 7 years ago

Going to close this now as this is an issue in the template polyfill. We could change the dep key here to be "template", but that'd be incorrect because there's already a package called "template".

matthewrobb commented 7 years ago

I think you should keep this issue open as it's likely hitting a lot of users and this issue would be helpful to have show up in the open issue list

treshugart commented 7 years ago

@matthewrobb sure no problem.

treshugart commented 7 years ago

This has been merged! We should now update it and then we can close this.

elmariofredo commented 7 years ago

That's my mistake so sending fixing PR #39

treshugart commented 7 years ago

Ah no probs, it needed fixing anyways :)