search

skatejs / web-components

[DEPRECATED] - The frictionless way to use the webcomponents/webcomponentsjs polyfills.
MIT License
17 stars 4 forks source link

update native-shim? #42

Closed micahscopes closed 7 years ago

micahscopes commented 7 years ago

I was experiencing an issue with native-shim's implementation of setAttribute. It was automatically lower-casing attribute names, which interfered with my svg application (svg elements have some important camelCase attributes). Turns out this is fixed in newer versions of webcomponents/custom-elements (see here: https://github.com/webcomponents/custom-elements/issues/14)

In my fork of this repository, I've upgraded to a newer version of custom-elements (v1.0.0-alpha.4). It fixed my problem and passed all the tests. Mind if I do a pull request? While I'm at it, I could also upgrade the cloudydom dependency to 1.0.2.

treshugart commented 7 years ago

Yep, pls bump!

micahscopes commented 7 years ago

hm, working on it now, except I'm having that sed issue again, this time with both yarn and npm!

micahscopes commented 7 years ago

Take care of by #43.