search

skatejs / web-components

[DEPRECATED] - The frictionless way to use the webcomponents/webcomponentsjs polyfills.
MIT License
17 stars 4 forks source link

Updated dependencies + webpack plugin replacement for sed native-shim backtick modifier. #43

Closed micahscopes closed 7 years ago

micahscopes commented 7 years ago

Ooh, it's probably not! I actually am not that familiar with node, so didn't realize that was built in

On Feb 24, 2017 6:10 PM, "Trey Shugart" notifications@github.com wrote:

@treshugart commented on this pull request.

In package.json https://github.com/skatejs/web-components/pull/43#discussion_r103059155:

 "es6-promise": "^4.0.5",

"object.assign": "^4.0.4" }, "devDependencies": { "cz-conventional-changelog": "1",

  • "fs": "^0.0.1-security",

Why is this needed over just using the standard node fs module?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/skatejs/web-components/pull/43#pullrequestreview-23839291, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXylruc_dyeo7d3QVl8Q1O31-WV3hcJks5rf3F-gaJpZM4MLxtb .

micahscopes commented 7 years ago

Btw, I considered using nf to do a more straightforward replacement of the shell stuff, but decided to go this more drawn out way.