Safari UA sniffing breaks in mobile chrome

skatejs / web-components

[DEPRECATED] - The frictionless way to use the webcomponents/webcomponentsjs polyfills.

MIT License

17 stars 4 forks source link

Safari UA sniffing breaks in mobile chrome #45

Open alexlafroscia opened 7 years ago

alexlafroscia commented 7 years ago

The UA sniffing here:

https://github.com/skatejs/web-components/blob/9c45414c2356603da3d14c19838fb34a14a60675/src/index.js#L30

does not work for Chrome for iOS's user agent. You end up with a JavaScript exception that prevents the file from loading. The erroneous user agent is:

Mozilla/5.0 (iPhone; CPU iPhone OS 10_3_1 like Mac OS X) AppleWebKit/602.1.50 (KHTML, like Gecko) CriOS/57.0.2987.137 Mobile/14E304 Safari/602.1

treshugart commented 7 years ago

Might be okay to remove this soon if Safari stable has the fix for that.