search

skateshop / sublime-javascript-refactor

Sublime 3 plugin that provides refactoring support for JavaScript
MIT License
3 stars 0 forks source link

Preview Changes Setting #7

Open jayfunk opened 8 years ago

jayfunk commented 8 years ago

Have default setting that will preview the changes before committing them. This view should be similar to the find all buffer and being able to navigate those changes with clicks or keyboard shortcuts. Saving that buffer will close it and commit the changes. Closing the buffer without a save will abort the operation

jurassix commented 8 years ago

This feature requires changes to jscodeshift around their reporting. I've opened an issue, FB was unresponsive until I closed it. They may be interested in a PR once I fork and do the work. I've found the extension points I need inside jscodeshift, seems pretty straightforward.

Remaining pieces are what is the contract to return? At the basic level we need which files would be change. Next it would be great to just return new source and we can do a diff on our end. Or possibly figure out some way of just sending the lines that changed. etc.