skavngr / rapidscan

:new: The Multi-Tool Web Vulnerability Scanner.
GNU General Public License v2.0
1.69k stars 385 forks source link

unique output file names #35

Closed zenfish closed 1 year ago

zenfish commented 2 years ago

stomping over the same file with all sorts of results... well... not even worth a pull request... but I added a few lines to disambiguate them - the main bit is:

date = subprocess.Popen(["date", "+%Y-%m-%d.%s"],stdout=subprocess.PIPE).stdout.read()[:-1].decode("utf-8") debuglog = "rs.dbg.%s.%s" % (target, date) vulreport = "rs.vul.%s.%s" % (target, date)

That will create files that look like "rs.vul.google.com.2022-01-03.1641255361" or w/e.

I'd also advocate creating a vulnerability file even if nothing was found; e.g. change this:

if len(rs_vul_list)==0: print("\t"+bcolors.OKGREEN+"No Vulnerabilities Detected."+bcolors.ENDC)

To be a report.write(*) with the same text or w/e (not blank, since it could die in mid run and you wouldn't know if it really was zero vuls or not.) First time I ran it I wasn't sure if there was a bug or what, since no result file was created.

YMMV, IMHO, etc.

tristanlatr commented 2 years ago

Sending an actual PR would be good.

luisjmoreno commented 2 years ago

First off, great tool, thank you extremely helpful!

@sh4nx0r or @tristanlatr just wondering if there are any updates on this recommendation. It be really great to have reports that display RS-*_servername_date.

Thank you,

tristanlatr commented 2 years ago

This is a good recommendation and I would be happy to see a PR that fixes this issue.

bhaveshraj336 commented 1 year ago

@sh4nx0r @tristanlatr #45 i have made a pull request for these issue