search

skb1129 / react-native-change-icon

Change your application icon programmatically for React Native apps
MIT License
500 stars 92 forks source link

[Bonnmh] - [30/01] - hide alert success iOS #102

Open bonnmh opened 10 months ago

bonnmh commented 10 months ago

Appstore is completely approved, I think it will help many people

vozaldi commented 9 months ago

This patch works well

skb1129 commented 8 months ago

@bonnmh seeing as this is a custom implementation for the inbuilt function, can you please add some error handling? Also, can you please move the React Native reject/resolve function calls to the function you've written?

litinskii commented 8 months ago

@skb1129

@bonnmh seeing as this is a custom implementation for the inbuilt function, can you please add some error handling? Also, can you please move the React Native reject/resolve function calls to the function you've written?

i think it works as same as this part of code that was before (on error it do nothing without using resolve/reject for RN) 

       [[UIApplication sharedApplication] setAlternateIconName:newIconName completionHandler:^(NSError * _Nullable error) {
            return;
        }];
bibhuti9 commented 1 month ago

@bonnmh Thanks for this feature.