search

skb1129 / react-native-change-icon

Change your application icon programmatically for React Native apps
MIT License
500 stars 92 forks source link

no effect when built as standalone iOS app #104

Closed castdrian closed 8 months ago

castdrian commented 8 months ago

Platform

Description

it seems that the package has no effect when the application is built as standalone using xcodebuild instead of expo cli

using expo run:ios works perfectly fine both on iOS simulator and real iOS device using 

 expo prebuild --platform=ios && cd ios && xcodebuild -workspace project.xcworkspace -scheme project -configuration Release -derivedDataPath build -destination generic/platform=iOS CODE_SIGN_IDENTITY=\"\"

to build a standalone iOS app however yields in no icon change whatsoever

To Reproduce Steps to reproduce the behavior:

  1. Build a standalone iOS application
  2. initiate an icon change

Expected behavior The icon should change and the alert should show, it however only does so when ran via expo run

Device (please complete the following information):

Versions

Code Snippet Just the default example code. Full project is located at https://github.com/castdrian/mw-native

This seems to happen with all dynamic app icon libs, same behavior with expo-dynamic-app-icon and rn-dynamic-icon they only work when installed via expo cli but don't when built as standalone via xcodebuild

castdrian commented 8 months ago

This appears to related to how paid certificates and local certificates differ in assigning app ids, unfortunately doesn’t seem to be fixable