skb1129 / react-native-change-icon

Change your application icon programmatically for React Native apps
MIT License
451 stars 78 forks source link

[Android] Changing the app icon will shut down the process. (v5.0.0) #106

Open Jongkeun opened 3 weeks ago

Jongkeun commented 3 weeks ago

Platform

Description This is such an obvious error. Changing the app icon on Android will shut down the process. I made a new project and tried it. But it was the same Please share the sample project repository that the app icon changes normally

To Reproduce Steps to reproduce the behavior:

  1. Install this library and follow the steps that is on How to Use
  2. call changeIcon on Android.

Expected behavior The app will not shut down and only the icon will change.

Screenshots Don't have to attach this.

Device (please complete the following information):

Versions

Code Snippet

<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.appname">
  <uses-permission android:name="android.permission.INTERNET"/>
  <application android:name=".MainApplication" android:label="@string/app_name" android:icon="@mipmap/ic_launcher" android:roundIcon="@mipmap/ic_launcher_round" android:allowBackup="false" android:theme="@style/AppTheme">
    <activity android:name=".MainActivity" android:label="@string/app_name" android:configChanges="keyboard|keyboardHidden|orientation|screenLayout|screenSize|smallestScreenSize|uiMode" android:launchMode="singleTask" android:windowSoftInputMode="adjustResize" android:exported="true">
      <intent-filter>
        <action android:name="android.intent.action.MAIN"/>
      </intent-filter>
      <intent-filter>
        <action android:name="android.intent.action.VIEW"/>
        <category android:name="android.intent.category.DEFAULT"/>
        <category android:name="android.intent.category.BROWSABLE"/>
        <data android:scheme="appname"/>
      </intent-filter>
    </activity>

      <activity-alias
            android:name="MainActivityDefault"
            android:enabled="true"
            android:exported="true"
            android:icon="@mipmap/ic_launcher"
            android:targetActivity=".MainActivity">
            <intent-filter>
                <action android:name="android.intent.action.MAIN" />
                <category android:name="android.intent.category.LAUNCHER" />
            </intent-filter>
        </activity-alias>
        <activity-alias
            android:name="MainActivityDark"
            android:enabled="false"
            android:exported="true"
            android:icon="@mipmap/ic_launcher"
            android:targetActivity=".MainActivity">
            <intent-filter>
                <action android:name="android.intent.action.MAIN" />
                <category android:name="android.intent.category.LAUNCHER" />
            </intent-filter>
        </activity-alias>
  </application>
</manifest>
TierryBr commented 3 weeks ago

I also have the same problem, any solution?

psjostrom commented 1 week ago

Same here.

jacobmolby commented 1 week ago

It's the only way to change app icon for Android. For instance check out the duckduckgo app.

Best thing you can do is to warn the user about what is about to happen.

Jongkeun commented 1 week ago

It's the only way to change app icon for Android. For instance check out the duckduckgo app.

Best thing you can do is to warn the user about what is about to happen.

@jacobmolby , you can check this feature at Todoist. It looks like there are some workaround way. They are doing without closing.

jacobmolby commented 1 week ago

It's the only way to change app icon for Android. For instance check out the duckduckgo app. Best thing you can do is to warn the user about what is about to happen.

@jacobmolby , you can check this feature at Todoist. It looks like there are some workaround way. They are doing without closing.

Interesting. So I've tried. In their implementation, you have to restart the app "to enable icon switching" but after that it works without closing.

I found this repo trying to implement something similar, but I haven't tried it out. https://github.com/gonodono/app-icon-change-demo.