search

skb1129 / react-native-change-icon

Change your application icon programmatically for React Native apps
MIT License
500 stars 92 forks source link

Warning about missing implementation of requiresMainQueueSetup #24

Closed mitjaz closed 3 years ago

mitjaz commented 4 years ago

Platform

Description A warning is shown that the module does not implement requiresMainQueueSetup. Module ChangeIcon requires main queue setup since it overridesinitbut doesn't implementrequiresMainQueueSetup. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of.

To Reproduce Steps to reproduce the behavior:

  1. Install a react-native-change-icon on a fresh initialized project

Expected behavior Not to display the warning

Screenshots

Screenshot 2020-11-09 at 17 00 42

Device (please complete the following information):

Versions

skb1129 commented 3 years ago

@mitjaz guys I have just released a beta version fixing this issue, please try it once, if this works then I'll create a major release on NPM.

samjusaitis commented 3 years ago

Worked for me! thanks

skb1129 commented 3 years ago

Closing this issue, it has been fixed.