search

skb1129 / react-native-change-icon

Change your application icon programmatically for React Native apps
MIT License
500 stars 92 forks source link

iOS:Explicitly initialize in background thread #35

Closed yuji77 closed 3 years ago

yuji77 commented 3 years ago

This module has been very helpful. Thanks a lot.😊 I was always getting warnings because it didn't specify whether the initialization of the swift class should be done in the main thread or the background thread. Therefore, I have explicitly specified that it should be done in the background thread.

zachgibson commented 3 years ago

This code already exists? https://github.com/skb1129/react-native-change-icon/blob/master/ios/ChangeIcon.swift#L5

zachgibson commented 3 years ago

Looks like it hasn't been published to NPM. @skb1129 Would you mind publishing to NPM so we can get this change?

skb1129 commented 3 years ago

Yes, it is already there, thanks for pointing it out @zachgibson. I'll publish a new version soon. Thanks, @yuji77 for the PR, I'll be closing it.