search

skb1129 / react-native-change-icon

Change your application icon programmatically for React Native apps
MIT License
500 stars 92 forks source link

Fix: Added support for changing the icon more than once on android #42

Closed MaxMSolutions closed 3 years ago

MaxMSolutions commented 3 years ago

When working with this package, I ran into a defect on android that caused multiple icons to be displayed when you hit the changeIcon method more than once before putting the app into the background.

In reviewing the code, it looked like the root cause was related to only ending one of the active activities after attempting to apply multiple icons.

I'm new to Kotlin and how you've composed this library, feel free to let me know if this solution is incorrect.

Thanks, Max

skb1129 commented 3 years ago

@MaxMSolutions Thank you!

MaxMSolutions commented 3 years ago

@MaxMSolutions Thank you!

No problem! Happy to help!