skclusive / Skclusive.Material.Component

Port of Material-UI in C# for Blazor
https://skclusive.github.io/Skclusive.Blazor.Samples/Dashboard
MIT License
397 stars 54 forks source link

Chip and ChipSet #42

Closed henon closed 4 years ago

henon commented 4 years ago

I started working on a Chip implementation because it is a fairly simple component and thus ideal for me to learn what it takes to add components to this library.

image

The code is still incomplete but already PRed as #44

henon commented 4 years ago

@skclusive I have this problem that the ripple doesn't show. Instead I see a thick black border on click image

Since it happens with <Button> too (which I haven't changed) I guess it means I didn't import something, but I can't figure out what I'm missing. I did import all Material styles and installed all the services.

<MaterialScripts />
<MaterialStyles />

@*<ThemeProvider Theme="@Theme.Dark" />*@

Maybe you have had this problem and instantly know what I missed?

henon commented 4 years ago

OK, The black border is caused by bootstrap.min.css. As soon as I removed it, it goes away. The ripple not showing is because I tested with a Blazor Server project. I raised an issue for that: #45

skclusive commented 4 years ago

@henon again apologies for the delayed response. bootstrap css by default affects standard components someway. when we have conflicting css, checking the styles sources in browser devtools will be easier. and regarding ripple on server, will comment on the issue.

and great for start implementing new components.

henon commented 4 years ago

it is coming along nicely image

henon commented 4 years ago

Chip is done:

image

skclusive commented 4 years ago

thanks for the great contribution. i am closing the issue.