search

skeeks-semenov / yii2-assets-auto-compress

Automatic compilation of js + css + html
https://skeeks.com/
BSD 3-Clause "New" or "Revised" License
157 stars 43 forks source link

Why Minify_CSS::minify and CssMin::minify #56

Open adoerler opened 4 years ago

adoerler commented 4 years ago

Hi,

if cssFileCompile is enabled, each file configured in the asset gets minified (using Minify_CSS::minify) at: https://github.com/skeeks-semenov/yii2-assets-auto-compress/blob/master/src/AssetsAutoCompressComponent.php#L534

If cssFileCompress is enabled, it will get minified a few lines later again (using CssMin::minify): https://github.com/skeeks-semenov/yii2-assets-auto-compress/blob/master/src/AssetsAutoCompressComponent.php#L568

I think complie should only concatenate the asset files into a single CSS file and it should compress this single CSS file only once and only if cssFileCompress is enabled.

What do you think? Andreas