search

skeema / tengo

Go La Tengo: a MySQL automation library
Apache License 2.0
27 stars 19 forks source link

-- Fix to support bit fields when generating DDL statements. #5

Closed efixler closed 6 years ago

efixler commented 6 years ago

The entirety of the fix is to add a condition at line 158 of schema.go to specify non-quoted handling for default bit values.

There is also an update to aTable() in test fixture generator to add a bit column to the schema.

There is one test that is failing: --- FAIL: TestTableAlterModifyColumn (0.00s) table_test.go:314: Incorrect number of table alters: expected 3, found 4

I think that the test is making assumptions about the number of columns in the table fixture and I wasn't certain of exactly the right approach here. If you have an idea I can take a stab at it, or feel free to modify the test :)

evanelias commented 6 years ago

Looks great, thanks! I'll merge this PR and then will fix the test in a subsequent commit on my end.

Normally I'd handle the test fix more gracefully, but I already plan on revamping the test setup soon anyway 😄