skeema / tengo

Go La Tengo: a MySQL automation library
Apache License 2.0
27 stars 19 forks source link

Remove caching and simplify method args and returns #7

Closed evanelias closed 6 years ago

evanelias commented 6 years ago

This PR removes the internal caching of instances and schemas, and simplifies the args and/or return values of several methods by removing lazy-loading. The built-in caching and lazy-loading added too much complexity for too little benefit. Callers should implement more appropriate special-purpose caching if ever needed.

This is a breaking API change, which is acceptable since Go La Tengo is still pre-1.0. The following method signatures or return semantics changed:

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 13


Changes Missing Coverage Covered Lines Changed/Added Lines %
ddl.go 28 29 96.55%
instance.go 265 294 90.14%
<!-- Total: 313 343 91.25% -->
Files with Coverage Reduction New Missed Lines %
instance.go 3 84.86%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 9: 0.7%
Covered Lines: 1369
Relevant Lines: 1587

💛 - Coveralls