search

skeeto / skewer-mode

Live web development in Emacs
The Unlicense
1.1k stars 57 forks source link

Report error location in skewer-repl #31

Closed starstuck closed 11 years ago

starstuck commented 11 years ago

This change adds line with file name and column where error is reported.

It takes advantage of emacs built-in compilation error highlighting. If you set up 'skewer-path-strip-level' and 'compilation-search-path' right according to your project, you will be even able to clik on error line in skewer-repl buffer, and you will be taken to file and line where error occurred. Very useful if you do TDD style development.

skeeto commented 11 years ago

Interesting. I was aware of this minor mode from byte-compilation but I never paid attention to it. I'm skeptical about the usefulness of this to Skewer, but it works and it's not in the way so I'll accept it. I did some touching up and merged it as 7b32d9ede13769ba391a6ab4924992686adad30f.

I tweaked the domain part of the regexp to be more tolerant. In its original form it wouldn't allow a portspec ("http://localhost:8080/"), which is something that comes up a lot with Skewer. I also dumped a debug messages you left behind and added a paragraph about this to the header.