skejeton / education-tool

Interactive story software
4 stars 0 forks source link

Cannot run release builds: DLLs missing #2

Closed vtereshkov closed 1 year ago

vtereshkov commented 1 year ago

image image image image

skejeton commented 1 year ago

I'm looking into it rn

skejeton commented 1 year ago

Does this help: https://learn.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?view=msvc-170#visual-studio-2015-2017-2019-and-2022 ?

vtereshkov commented 1 year ago

@skejeton No, it doesn't, as I have already told you. My conjecture is that this *.exe is in fact a debug build rather than a release one, so that it expects the debug versions of those DLLs (notice the D suffix in the DLL names).

On the other hand, when I run the same *.exe on another machine with Visual Studio installed, it no more complains about the DLLs, but immediately crashes on a failed assertion:

image

vtereshkov commented 1 year ago

@skejeton The only way to run the app I have found so far is to clone the repo and rebuild everything from scratch:

image

vtereshkov commented 1 year ago

@skejeton I have finally figured out what we need to fix this issue:

skejeton commented 1 year ago

Hmm interesting because I thought the builds were already compiled in release mode. I'll fix the CI right now.

skejeton commented 1 year ago

Yes indeed the build script used debug builds.

skejeton commented 1 year ago

@vtereshkov Can you confirm the CI builds work with the most recent build?

vtereshkov commented 1 year ago

@skejeton Your latest Git LFS fix CI has failed -- please check it. Without this fix, I only have symlinks, not the actual assets.

skejeton commented 1 year ago

Yeah I saw that. I'm working on it right now.

skejeton commented 1 year ago

@vtereshkov Should be all fixed.

vtereshkov commented 1 year ago

@skejeton Confirmed and closed.