search

skejeton / education-tool

Interactive story software
4 stars 0 forks source link

Styling solution #34

Open skejeton opened 4 months ago

skejeton commented 4 months ago

Currently the UI has very little versatility, every UI element has one single style that I can't change. I can't change color of the buttons without ad hoc parameters, color of the text, e.t.c.

skejeton commented 4 months ago

33

matejovic commented 4 months ago

Would be nice to work with design system and colour schemes, so that all buttons can be styled at a single spot. On the other hand this is not important for the editor itself. It's totally fine to keep a single interface for it as long as it looks reasonable.

For the game, it would be nice to add styles / chose existing theme in the editor or a script.

As for DX, well made themes are always easier to maintain and rewrite than hundreds of ad-hoc design choices made all around the codebase.

skejeton commented 4 months ago

How do you think this should be done? Do we just make builder functions, or a language akin to CSS?

Matoo125 commented 4 months ago

As long as we speak about colour schemes I’d imagine very minimalistic style sheet file or simple key value pairs per scheme.

Otherwise I’d focus on a single interface that looks good before adding customisation layer.

On Fri, 23 Feb 2024 at 23:45, matejovic @.***> wrote:

Can you show API examples for both options? Any other trade-offs to consider?

On Fri, Feb 23, 2024, 1:31 PM ske @.***> wrote:

How do you think this should be done? Do we just make builder functions, or a language akin to CSS?

— Reply to this email directly, view it on GitHub < https://github.com/skejeton/education-tool/issues/34#issuecomment-1961244989>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/BDPTIM4WNFI3LHGJ26HHFPTYVCD2DAVCNFSM6AAAAABDUZMY3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRRGI2DIOJYHE>

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/skejeton/education-tool/issues/34#issuecomment-1962097984, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQAZO2SAIUWYW6AEUZOBMTYVELZFAVCNFSM6AAAAABDUZMY3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRSGA4TOOJYGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

matejovic commented 2 months ago

with out current perspective: let's keep the UI simple and non-adjustable.