search

skeletonlabs / create-skeleton-app

CLI installer for Skeleton apps and monorepo for the sites that form the templates
16 stars 5 forks source link

Feature request: support CLI install in existing folder #2

Closed henrikvilhelmberglund closed 1 year ago

henrikvilhelmberglund commented 1 year ago

Describe what feature you'd like. Pseudo-code, mockups, or screenshots of similar solutions are encouraged!

It would be nice if Skeleton could support an existing folder install, I know SvelteKit allows this (not specifying a folder in the npm command and then not specifying a name when asked for the folder).

When done in Skeleton this gives an error: Install directory already exists!

What type of pull request would this be?

None

Any links to similar examples or other references we should review?

No response

endigo9740 commented 1 year ago

@henrikvilhelmberglund @niktek FYI I've moved this over to the proper project repo. Thanks for the suggestion!

henrikvilhelmberglund commented 1 year ago

@henrikvilhelmberglund @niktek FYI I've moved this over to the proper project repo. Thanks for the suggestion!

Woops, thanks. 😄

niktek commented 1 year ago

Just want to check here - is this into a new empty folder or an existing install? Because SK will overwrite an existing install and blow away all your changes, which is why I added that check in there. I could tweak the check to make sure the folder is empty, but it gets super complicated to try and reason with an existing install and overlay the skeleton stuff on top without breaking things.

niktek commented 1 year ago

This is now updated to allow install into a current empty directory