Open BA-CalderonMorales opened 1 year ago
Tested in VSCode terminal on macOS:
The prompts are from a lib called clack/prompts https://www.npmjs.com/package/@clack/prompts which is used by create-svelte CLI as well. Maybe try testing with a different terminal program ?
Just checking if you got a chance to test in another terminal or try adjusting your vscode terminal settings ?
Did you try it on Windows OS (11) VS Code? Not sure if that would make any difference. I'll also check my version of VS Code and will post my terminal settings too later today.
I'll also try on my git bash terminal later today to see if I can replicate the bug outside of VS Code.
Actually, it appears the clack library has an issue with this. It's already been reported. clack #116 I think?
https://github.com/natemoo-re/clack/issues/116
or is this unrelated?
I tested it on windows (10) vs code, with cmd, powershell and bash terminals, I can't reproduce it!
May sound a bit pretentious here, just wanted to point this out. When I was trying to create my starter app, I was a bit thrown off by the theme selection. I know that I have to press space to select the specific theme, but I kept getting an infinite loop when I pressed the down key on my keyboard.
For a baseline behavior, if there are a list of options I can select from, I would expect the list to not let me continue loop to the top of the list. Instead, I would want the down key to just stop at the last option, and just let the user press the up key to go back to the first option.
Here is what the output looks like in the console (may also just be a VS Code terminal problem?):
When I finally make my selection and move on:
I tried looking at the code here: https://github.com/skeletonlabs/create-skeleton-app/blob/e5dedea236a970213b0b71cf170b8eb05347d765/src/index.js#L231 to see if I could spot the issue, but it looks like it's nothing out of the ordinary (might not even be the right spot to look at to begin with considering it doesn't look like the full list of themes anyways, so maybe in another file somewhere).
Just wanted to point this out for you guys. The cli tool was pretty nice apart from this!