search

skeletonlabs / create-skeleton-app

CLI installer for Skeleton apps and monorepo for the sites that form the templates
16 stars 5 forks source link

Faux Italic and Faux Bold Issue in iPhone Safari #47

Open Typogram opened 12 months ago

Typogram commented 12 months ago

https://github.com/skeletonlabs/skeleton/issues/2188#issue-1959804406

Current Behavior

There seems to be a typography issue with the heading font in the Seafoam Theme. The Playfair Display Italic is registered as a normal style, causing the font to undergo a 'faux italic' transformation by the browser's algorithm, which results in an undesired appearance.

Screenshots: Faux italic (iPhone safari) image

Correct rendering (Windows chrome) image

Expected Behavior

The italic style of the Playfair Display font should be displayed as intended without any additional skewing or faux italic transformation applied.

Actual behavior: The font is skewed further by the browser’s algorithm, creating a faux italic effect, which affects the typography aesthetics.

Steps To Reproduce

  1. Open iPhone Safari
  2. Navigate to the page with the Seafoam Theme applied
  3. Observe the heading font (Playfair Display Italic)

Link to Reproduction / Stackblitz

No response

More Information

Environment:

endigo9740 commented 12 months ago

@niktek @Mahmoud-zino we'll need a fix on the CLI side for this issue. You can see the issue described above, and @Typogram PR fix for our doc site here:

https://github.com/skeletonlabs/skeleton/pull/2192/files

Just make sure to match the style adjustments and all should be well.

Happy to assign whomever wishes to take this.

Mahmoud-zino commented 11 months ago

@endigo9740 I am afraid I can't test it since it is Safari related bug. If nik doesn't have the time, I can create the PR with the suggested solution and let the testing for you...

endigo9740 commented 11 months ago

@Mahmoud-zino per the PR linked, I pointed out that I don't believe the original issue to be solved in full yet. The original contributor will review. Maybe give this a couple days and check back. Once your changes are in place, perhaps Nik or I can help test for you though