search

skeletonlabs / skeleton

A complete design system and component solution, built on Tailwind.
https://skeleton.dev
MIT License
4.89k stars 305 forks source link

Drawer in Safari isn't smooth #1848

Closed Zerotask closed 1 year ago

Zerotask commented 1 year ago

Current Behavior

If I use the Drawer on https://www.skeleton.dev/utilities/drawers with the latest safari, the transition isn't smooth. It's a bit laggy. In Brave for example, it's smooth though.

Expected Behavior

Same smooth behavior as in Brave/Chrome.

Steps To Reproduce

  1. Open Safari
  2. Open https://www.skeleton.dev/utilities/drawers
  3. Click on the first example

Link to Reproduction / Stackblitz

No response

More Information

No response

niktek commented 1 year ago

Hey @Zerotask

Any chance you could get a screen capture ? (I recommend Kap if you don't have one already) - I just tested this on an M1 8GB mini - pretty much the weakest Mac you can have and the animations didn't seem too different to me.

Zerotask commented 1 year ago

https://github.com/skeletonlabs/skeleton/assets/20150243/8cc04609-efe1-4c8b-b41e-a8f94539dfaa

You can barely see it in the recording at the first 2 clicks. The third one looks smoother.

endigo9740 commented 1 year ago

@Zerotask we've seen a few instances where Svelte-provided transitions do not always animate smoothly on Safari specifically. For example, we had issues reported regarding the accordion in the past. Unfortunately this is just how they operate, and it would ben upstream issue. Perhaps even a browser issue depending on how these are implemented. There's nothing we can do - trust me, we devoted a lot of time and effort into trying to resolve that.

One thing of note though, in the new v2 version of Skeleton we are introducing a new dynamic transition system. This means that similar to modifying styles with props, you can how pass custom transition to your components. Again, this won't solve the root problem, but it does provide a means for you to modify some the transitions used here if Safari is at the forefront of your user base.

The v2 release candidate drops on Tuesday next week. Maybe give it a go when you have a chance to migrate?

Zerotask commented 1 year ago

@endigo9740 Thank you for your fast and detailed answer.