skeletonlabs / skeleton

A complete design system and component solution, built on Tailwind.
https://skeleton.dev
MIT License
5.15k stars 321 forks source link

WIP: Made progress ring show label on demand #2996

Open phamduylong opened 5 hours ago

phamduylong commented 5 hours ago

Linked Issue

Closes #2992

Description

Made label show only on demand

TODO: update site examples and generate changesets

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

changeset-bot[bot] commented 5 hours ago

⚠️ No Changeset found

Latest commit: 775176ba132a796d467bb6f5802e7fddf63d1821

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 5 hours ago

@phamduylong is attempting to deploy a commit to the Skeleton Labs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 5 hours ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ❌ Failed (Inspect) Nov 22, 2024 3:17pm
phamduylong commented 5 hours ago

Looks great Long. If you could make these couple minor changes and supply the documentation updates requested, then this should be good to go.

Yeah it's not finished yet, there's no draft flag on PR in GitHub it seems. I'll probably get it done soon enough when I figure out how to update site examples and refactor the stuff you pointed out. Thanks for the review.

endigo9740 commented 5 hours ago

There's an option when creating PRs to mark it as a draft, otherwise they have a super tiny option on the sidebar near where you assign reviewers. Not sure why it's not more obvious, but it is there! :)

Screenshot 2024-11-22 at 9 41 45 AM