Open endigo9740 opened 13 hours ago
@Hugos68 FYI, it looks like there was a major release to Astro and/or @astro/mdx
that is triggering two issues and may prevent us from updating to Astro v5 for now...
First, the getCollections()
method in Astro is no longer returning a slug
per item. If you hover item
it still shows this as a required value, but this is missing when you actually log the value. This is affecting a number of components in our app, including:
We can substitute item.slug
with item.filePath?
as a quick fix fix.
Second, when switching to any page that has MDX rendered, there is a very obvious flash of styled content. However if you switch to a page that does not include MDX (ex: /news) this does not occur. I'm guessing this is either related to some pre-rendering or some new issues between the layout & rendered MDX.
https://github.com/user-attachments/assets/b0eb2d60-6594-476e-9b55-3ab450461c19
I'd welcome your support in troubleshooting these if possible. The PR is here if you would like to test directly:
Steps to reproduce:
pnpm update -i -L
to update all packages and package.json
slug
issue (see the fix above)FYI I've pushed some additional changes:
pnpm outdated
didn't show these for some reason).Unfortunately I noticed we're also having issues with the current PR's CI checks...
The "check" step is showing this Astro-check error, even though Astro has yet to be updated. For some reason I cannot replicate this locally. It's like it's running a version head of my local instance - even though I specifically avoided updating the Astro project.
Additionally the "lint" step is failing as well. Best I can tell it seems to be running eslint v9
even though the monorepo root's package.json specifies eslint v8
. The v9 updates has some major breaking changes, which do not seem trivial to implement so we're purposely trying to stick with v8 for now.
No idea why it's running v9, my local instance shows the same with pnpm lint
, but the package.json clearly indicates the following:
"eslint": "^8.57.1",
Similarly the "test" step is failing. It seems to indicate an issue with Zag within one of the Svelte components. Once again, I can't seem to replicate this when running pnpm test
locally from the monorepo root.
I'm feeling frustrated with so many breaking issues, so I'm just going to pause here for the day. If anyone has any ideas on these I'm all ears.
We should go ahead and update all project dependencies and check for regressions.
This will include a notable update to Astro 5, which now utilizes Vite 6: https://astro.build/blog/astro-5/
As well as migrating all projects to a minimum of Node 22, to satisfy and upcoming change on Vercel:
Once changes changes are pushed, all contributors should be encouraged to update to use Node 22 on their local machines.