search

skellock / typescript-with-electron-react-kit

Don't just start your Electron app... TWERKit.
https://skellock.github.io/typescript-with-electron-react-kit
MIT License
145 stars 23 forks source link

Script "clean" fails on windows #120

Open skairunner opened 6 years ago

skairunner commented 6 years ago

The rm command line utility does not exist on Windows, so all scripts that require "clean" fail on Windows.

skairunner commented 6 years ago

Related, compile fails with the following error:

'NODE_ENV' is not recognized as an internal or external command,
operable program or batch file.

Another Windows batch difference, I imagine.

skellock commented 6 years ago

For the first issue, I've seen people use yarn add --dev rimraf and yarn add --dev trash to get around that. If you're feeling up for a PR, that'd be sweet.

For the 2nd issue, I'm not sure how windows sets their environment variables. hmmm... I'll have to look into that one. Unless you know?

skairunner commented 6 years ago

SET NODE_ENV=[whatever], I believe. I'm not sure how you would change the script to figure out when it's on windows vs a POSIX-y system, tho.