search

skellock / typescript-with-electron-react-kit

Don't just start your Electron app... TWERKit.
https://skellock.github.io/typescript-with-electron-react-kit
MIT License
145 stars 23 forks source link

electron-updater marked as deprecated #85

Closed skellock closed 7 years ago

skellock commented 7 years ago

@rmevans9 was mentioning that electron-updater is now deprecated. This is coming in from electron-builder.

Let's find out the scoop before shipping 1.0.

rmevans9 commented 7 years ago

ref: https://github.com/develar/electron-updater

skellock commented 7 years ago

Wait, I'm a liar.

We've got a dependency on electron-updater.

And electron-builder doesn't.

Care to comment @skellock? 😊

rmevans9 commented 7 years ago

I believe this is not actually a bug...

Electron Updater lives here: https://github.com/electron-userland/electron-builder/tree/master/packages/electron-updater

NPM Points to electron-builder github: https://www.npmjs.com/package/electron-updater

The note clearly states that since 1.0.0 it has been a part of electron-builder: https://github.com/develar/electron-updater#note

I think this can be closed as a non-issue

skellock commented 7 years ago

Thx. Ya everything seems to indicate it is fine. Where did you see that it was deprecated?

rmevans9 commented 7 years ago

The title in the github repo that is/was used specifically for it:

https://github.com/develar/electron-updater (right at the top)

skellock commented 7 years ago

Ahh. Gotcha. Ok, that is now hosted in the builder monorepo.

Ok, cool. Good sleuthing.