skelsec / minidump

Python library to parse and read Microsoft minidump file format
MIT License
270 stars 55 forks source link

Update minidumpreader.py #15

Closed bestrocker221 closed 3 years ago

bestrocker221 commented 4 years ago

If that is not handled there are cases where the length does not match and so the file is not processed. This way it takes all the remaining bytes and finishes processing the file.

[not thoroughly tested, but without this i can't process my files]

skelsec commented 3 years ago

I believe this issue was solved by fixing a parsing error in the code. Your proposed solution is not ideal as it would silently ignore higher-level issues that will make them super-hard to debug when an exception happens later. I'll keep this in mind tho and might add a silent ignore flag in the future