search

skelsec / minidump

Python library to parse and read Microsoft minidump file format
MIT License
272 stars 55 forks source link

Context parsers #19

Closed slyles1001 closed 3 years ago

slyles1001 commented 3 years ago

Hello, a teammate and I wrote some code to extract thread context from minidump files. Please review and reach out if you have critiques or ideas for improvement!

Seth

skelsec commented 3 years ago

Hello, This is the largest (by effort) PR I have ever received, thank you very much. The only problem I see is: there is some functionality implemented in the ContextStream.py file which requires multiprocessing and numpy. Could it be possible to either move the imports to the main function (to hide them) or to create a separate script for this parsing functionality which we can store in the utils folder? Problem is that this functionality is not an integral part for the context parsing and thus would require all users to install huge packages (numpy) and include multiprocessing which is not always available (webassembly/other exotics) Please let me know if you wish to do it yourself or I can just accept the PR as-is and do it myself. Awesome work, I'm really grateful.

Best Regards, SkelSec

slyles1001 commented 3 years ago

Hey, I think that was an old commit; in the most recent (files changed) those packages are removed. I'll squash the commits and update, should get rid of it!

slyles1001 commented 3 years ago

ok, squashed to 2 commits, subprocessing and numpy should be gone (or buried) from history now

skelsec commented 3 years ago

You are awesome, thank you very much! hit me up on twitter if you want a shoutout