search

skelsec / minidump

Python library to parse and read Microsoft minidump file format
MIT License
271 stars 55 forks source link

About inrange() #35

Closed jhgl0419 closed 11 months ago

jhgl0419 commented 1 year ago

In order to print the entire contents of the memory segment, I entered the segment size in the '-s' option, but it did not work. So I looked at the inrange() code and found that "start_address <= position < end_address". However, since end_address must also be included, isn't "<= end_address correct"? image

skelsec commented 11 months ago

Every year this is a recurring topic. Last year it was a PR from @mrexodia which undid the previous year's change which was the way you're referring to.
Please discuss it, and come to a conclusion :)

mrexodia commented 11 months ago

Let me read up on the code again, I’ve been reading the full memory region without issues after my change in Dumpulator: https://github.com/mrexodia/dumpulator/blob/main/src/dumpulator/dumpulator.py#L455

mrexodia commented 11 months ago

Could you give the full command line you used for this? I checked the code and everything looks like it should work 🤷🏻