search

skelsec / minidump

Python library to parse and read Microsoft minidump file format
MIT License
271 stars 55 forks source link

fix: MINIDUMP_EXCEPTION parsing #38

Closed iPower closed 10 months ago

iPower commented 10 months ago

Context

A friend of mine was trying this library because he needs to parse some minidumps for a private project. Everything worked fine, except for the MINIDUMP_EXCEPTION parsing. Since the code wasn't actually considering the size of ExceptionInformation, it was leading to incorrect parsing of ThreadContext from MINIDUMP_EXCEPTION_STREAM.

Solution

Very simple! Just read the entire field and then copy the actual parameters, which is what this PR achieves.

skelsec commented 10 months ago

Cool! Thank you!